My best advice on what to take on a cruise is simple;
Take half as many clothes as you think you should pack and it'll be twice as much as you will need.
And take twice as many pictures as you want to take and it'll be half as many as you should have taken.
45 Cruises & Counting! Favorites: Paul Gauguin to Tahiti: Uniworld River Cruises in Europe; any of the Celebrity Solstice-class ships; Holland America for 12-nights in the Baltics & Russia; RCCL for 14-night Greek Isles, Turkey, & Croatia; Holland America for 14-day Alaska cruisetour; 10-night Canada/New England cruise; 21 days in Hawaii including a 7-night NCL cruise; Oceania for 25 days in Asia; & 3 months touring Europe by train. And many days spent in all-inclusive resorts!