My best advice on what to take on a cruise is simple;
Take half as many clothes as you think you should pack and it'll be twice as much as you will need.
And take twice as many pictures as you want to take and it'll be half as many as you should have taken.
Travel Agent/Cruise Specialist w/12 yrs exp and 47 Cruises on 11 cruise lines! Favorites: Paul Gauguin - Tahiti: Uniworld River Cruises - Europe; Celebrity Solstice-class ships; Holland America - 12-nights Baltics & Russia; RCCL - 14-nights Greek Isles, Turkey, & Croatia; Holland America - 14-day Alaskan cruisetour; 10-night Canada/New England cruise; 21 days Hawaii w/7-night NCL cruise; Oceania - 25 days in Asia; more than 3 months touring Europe by train. And many all-inclusive resorts!